Hey @bruce . Thank you to you and the GL team for getting this published appropriately! I’ll follow up on the github PRs directly, but it’s great to see RT & GL making an effort to honor the obligations when you’re building on other’s code and the linux GPL kernel symbols.
I see you guys are getting a little bit of a hard time from the upstream (but sorry, easy to see coming), but before it gets called out there, I’d like to make the GL team aware that you’re still publishing GPL files with conflicting (and “non legal”) restriction headers. It’ll probably be a moot point considering it looks like the OWRT team is going to rewrite the driver as DSA and ditch the GL/RT code, but it would be good to have GL on record with a proper clean commit.
”This software is a confidential and proprietary property of Realtek Semiconductor Corp. Disclosure, reproduction, redistribution, in whole or in part, of this work and its derivatives without express permission is prohibited.”. It looks a little silly to have that 4 lines down from the GPL-2.0 SPDX license identifier as they are 100% mutually exclusive statements.
Just as important. I see GL is repeating a similar mistake with the Astro* code. I’ve pointed it out here but it seems to be getting ignored by the GL team. I would hope GL wants to get ahead of this before it get’s noticed by upstream copyright holders for the clear violations and those communities are less amicable about it.
I really hope the team gets that all projects built on opensource have to include published source at the very same moment that GL is releasing firmware features built on it.