4.6.8 Admin Panel issue: characters that break dnsmasq config can be added when adding descriptions under LAN -> Address Reservation

Technical Support for Routers
1

Running a MT-2500, currently on Firmware 4.6.8

Was trying to set up static IPs via the LAN tab and wound up accidentally knocking everything off the network. Was only able to reconnect to the router after inputting IPs manually.

Noticed the following in the logs:
Tue Nov 19 22:36:43 2024 daemon.crit dnsmasq[6772]: missing " at line 57 of /var/etc/dnsmasq.conf.cfg01411c

Sure enough, the issue was that I'd put something like the following as a description for one of the entries:
65" TV

The UI was still able to read the config and never showed any errors, but the daemon couldn't start up, which meant that DHCP stopped working.

As soon as I removed the quote from the entry, everything was back to normal.

Seems like there's a need to do one or more of the following:

  • Do input validation and flag any special characters that could break the config
  • Set a pattern mask on the input field to restrict the characters that can be entered
  • Escape special characters when writing out the config
  • Add logic to test that the dnsmasq config is valid before / after writing
  • Add logic to highlight more prominently when dnsmasq fails to start
2 Likes
2

@bruce Sounds reasonable and might be added to R&D :slight_smile:

3

4.6.10 exists for the Brume 2:

I'm running it at present.

4

Any idea on the changelog for that firmware?

At this point it's back to working and I know what happened well enough to not trigger the bug again, so I'll probably just wait until 4.7.0 comes out of beta to update.

5

This issue we aware and submit to R&D. Thank you
You also sent an email to support team to report the issue, I hear that support team guys have been replied to you soon.