"keep settings" keeps bugs?

So I'm wondering. Obviously the firmware runs on openwrt and you guys released new firmware with bug fixes, adguard fixes, firewall rules for the VPN routing etc. When you are applying these fixes are these done at restricted level, by that I mean you are not modifying what Luci considered as settings? Could the fixes be in certain config files and potentially be overwritten by a older file from a backup archive for example.

The reason I ask is because I use SQM, adguard, upnp, ddns and it's easy just to restore my config that I make from within Luci after I upgrade, my concern is that when I restore I might inadvertently be restoring a file that you guys have edited?

Does the "keep settings" inside the GUI actually just run the backup / restore of Luci or is it different?

I know some upgrades say don't enable keep settings but it's a bit of a pain having to setup things again from scratch each time there's an update

So to sum up. Are the "keep settings" really just that, keeping the settings or are they keeping some files that could have been fixed in the newer firmware?

Keep settings will do a backup of all needed files before flashing the new firmware and restoring it afterward. So basically, it's the same mechanism and will keep bugs if they are related to config files.

Bugs comes from two kind of files,

  1. Files that will be restored from settings
  2. Files that will NOT be restored from settings

No 1. is generally config files. These config may not be compatibile with newer firmware so that is the reason you are advised not to keep settings.

No 2. are massive other files e.g. scripts or APIs that usually bugs comes from. These files is updated in newer firmware.

So "Keep Settings" does not keep bugs, it keeps old settings that may not be compatible with newer firmware.